linux-kernel - Re: [patch 3/6] [RFC] Add MMC Password Protection (lock/unlock) support V6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 17 Nov 2006 16:08:55 +0000
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Anderson Briglia <anderson.briglia@...t.org.br>
Cc:	"Linux-omap-open-source@...ux.omap.com" 
	<linux-omap-open-source@...ux.omap.com>,
	linux-kernel@...r.kernel.org,
	Pierre Ossman <drzeus-list@...eus.cx>,
	ext David Brownell <david-b@...bell.net>,
	Tony Lindgren <tony@...mide.com>,
	"Aguiar Carlos (EXT-INdT/Manaus)" <carlos.aguiar@...t.org.br>,
	"Biris Ilias (EXT-INdT/Manaus)" <Ilias.Biris@...t.org.br>
Subject: Re: [patch 3/6] [RFC] Add MMC Password Protection (lock/unlock) support V6

On Fri, Nov 17, 2006 at 09:03:24AM -0400, Anderson Briglia wrote:
> @@ -101,7 +104,7 @@ mmc_start_request(struct mmc_host *host,
>  	pr_debug("%s: starting CMD%u arg %08x flags %08x\n",
>  		 mmc_hostname(host), mrq->cmd->opcode,
>  		 mrq->cmd->arg, mrq->cmd->flags);
> -
> +	

Random whitespace damage; please remove.

> +	do {
> +		/* we cannot use "retries" here because the
> +		 * R1_LOCK_UNLOCK_FAILED bit is cleared by subsequent reads 
> to

#include <std-mail-wrapping-complaint.h>

> +error:
> +	mmc_deselect_cards(card->host);

You don't need to deselect the card prior to releasing the host; in
fact in single card systems, it's better that you don't.  That way
you avoid generating lots of select card messages.

> +	mmc_card_release_host(card);
> +out:
> +	kfree(data_buf);
> +
> +	return err;
> +}
> +
> +//EXPORT_SYMBOL(mmc_lock_unlock);

Either export it or don't.  There's no point in having a commented out
export.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/