linux-kernel - Re: [PATCH 1/10] cxgb3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adaejs1lp7l.fsf@cisco.com>
Date:	Fri, 17 Nov 2006 13:48:14 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Stephen Hemminger <shemminger@...l.org>
Cc:	"Divy Le Ray <divy@...lsio.com>" <divy@...lsio.com>,
	jeff@...zik.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/10] cxgb3 - main header files

 > > +#define MDIO_LOCK(adapter) down(&(adapter)->mdio_lock)
 > > +#define MDIO_UNLOCK(adapter) up(&(adapter)->mdio_lock)
 > 
 > Please don't wrap locks

Plus these should probably be mutexes, not semaphores.

 > > +int t3_offload_tx(struct t3cdev *tdev, struct sk_buff *skb);
 > 
 > What kind of offload?  You remember TOE was rejected.

But we're OK with RDMA over TCP (iWARP) I think...

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/