linux-kernel - Re: 2.6.19-rc5 nasty ACPI regression, AE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200611162222.44836.david-b@pacbell.net>
Date:	Thu, 16 Nov 2006 22:22:43 -0800
From:	David Brownell <david-b@...bell.net>
To:	Alexey Starikovskiy <alexey.y.starikovskiy@...ux.intel.com>
Cc:	Len Brown <lenb@...nel.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-acpi@...r.kernel.org
Subject: Re: 2.6.19-rc5 nasty ACPI regression, AE_TIME errors

On Thursday 16 November 2006 7:41 am, Alexey Starikovskiy wrote:
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -467,8 +467,8 @@ static u32 acpi_ec_gpe_handler(void *dat
>                 status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec);
>         }
>         acpi_enable_gpe(NULL, ec->gpe_bit, ACPI_ISR);
> -       return status == AE_OK ?
> -           ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED;
> +       WARN_ON(ACPI_FAILURE(status));
> +       return ACPI_INTERRUPT_HANDLED;
>  }
>  

Strange ... applying this on top of the previous patch seems to work
much better, but that WARN_ON hasn't triggered.  At least, not yet.
Updating to RC6, with your two patches installed...

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/