linux-kernel - Re: [PATCH] Regard MSRs in lapic_suspend()/lapic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 18 Nov 2006 08:03:10 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Karsten Wiese <fzu@...gehoertderstaat.de>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	Stephen Hemminger <shemminger@...l.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH] Regard MSRs in lapic_suspend()/lapic_resume()


* Karsten Wiese <fzu@...gehoertderstaat.de> wrote:

> Read/Write APIC_LVTPC and APIC_LVTTHMR only, if get_maxlvt() returns 
> certain values. This is done like everywhere else in 
> i386/kernel/apic.c, so I guess its correct. Suspends/Resumes to disk 
> fine and eleminates an smp_error_interrupt() here on a K8.
> 
> Signed-off-by: Karsten Wiese <fzu@...gehoertderstaat.de>

nice one! I'm tempted to suggest this for 2.6.19 merge because it causes 
the kernel to do less (so it has little risk of breaking something that 
is working) ... who knows what happens on certain (older?) APICs when we 
try to write back those bogus values.

  Acked-by: Ingo Molnar <mingo@...e.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/