linux-kernel - Re: [rfc patch] Re: sched: incorrect argument used in task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061118072832.GA4234@elte.hu>
Date:	Sat, 18 Nov 2006 08:28:32 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Chen, Kenneth W" <kenneth.w.chen@...el.com>
Cc:	'Mike Galbraith' <efault@....de>, Andrew Morton <akpm@...l.org>,
	nickpiggin@...oo.com.au,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [rfc patch] Re: sched: incorrect argument used in task_hot()


* Chen, Kenneth W <kenneth.w.chen@...el.com> wrote:

> -	if (sd->nr_balance_failed > sd->cache_nice_tries)
> +	if (sd->nr_balance_failed > sd->cache_nice_tries) {
> +		#ifdef CONFIG_SCHEDSTATS
> +		if (task_hot(p, rq->most_recent_timestamp, sd))
> +			schedstat_inc(sd, lb_hot_gained[idle]);
> +		#endif
>  		return 1;
> +	}

minor nit: preprocessor directives should be aligned to the first 
column.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/