linux-kernel - Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi type IRQ handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4560C121.30403@ru.mvista.com>
Date:	Sun, 19 Nov 2006 23:40:01 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Ingo Molnar <mingo@...e.hu>, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org, dwalker@...sta.com
Subject: Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoi
 type IRQ handlers

Hello.

Benjamin Herrenschmidt wrote:

>>    I must not that this whole ack() vs eoi() stuff is misleading. For example,
>>in 8259 driver, mask_ack() method actually sends EOI to PIC, not ACK's an IRQ 
>>-- the actual ACK is implicit on x86 and is used to read the interrupt vector 
>>form 8259 on PPC. So, IMO, there probably should only have been either ack() 
>>or eoi() method in the first place. Though I'm not familiar with ARM from 
>>which genirq stuff originated...

> They are different concepts. Ack clears the event on the PIC, it's
> tyically necessary for resetting the edge detection logic for edge
> interrupts and has to happen before the handler is called.

    I know 8259. :-)
    It also resets the corresponding IRQ bit in IRR, and sets it in ISR where 
it's then cleared on EOI command.

> On MPIC or XICS, this is implicit by reading the vector. On some more
> dumb controllers, this has to be done explicitely.

    This is not implicit -- CPU has to read INTACK reg. on OpenPIC. Really 
implicit method is in action on x86 where CPU issues dual ACK bus cycle to get 
the vector form 8259...

> EOI is a more "high level" thing that some "intelligent" PICs that
> automatically raise the priority do to restore the priority to what it
> was before the interrupt occured.

    Thank you, I know. Even 8259 has the notion of priority and EOI works the 
same way here.

> Ben.

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/