linux-kernel - Re: [PATCH 1/4] atl1: Build files for Attansic L1 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061119152432.a85d4166.randy.dunlap@oracle.com>
Date:	Sun, 19 Nov 2006 15:24:32 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jay Cliburn <jacliburn@...lsouth.net>
Cc:	jeff@...zik.org, shemminger@...l.org, romieu@...zoreil.com,
	csnook@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] atl1: Build files for Attansic L1 driver

On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:

> From: Jay Cliburn <jacliburn@...lsouth.net>
> 
> This patch contains the build files for the Attansic L1 gigabit ethernet
> adapter driver.
> 
> Signed-off-by: Jay Cliburn <jacliburn@...lsouth.net>
> ---
> 
>  Kconfig       |   12 ++++++++++++
>  Makefile      |    1 +
>  atl1/Makefile |   30 ++++++++++++++++++++++++++++++
>  3 files changed, 43 insertions(+)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 6e863aa..f503d10 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2329,6 +2329,18 @@ config QLA3XXX
>  	  To compile this driver as a module, choose M here: the module
>  	  will be called qla3xxx.
>  
> +config ATL1
> +	tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
> +	depends on NET_PCI && PCI && EXPERIMENTAL
> +	select CRC32
> +	select MII
> +	---help---
> +	  This driver supports Attansic L1 gigabit ethernet adapter.
> +
> +	  To compile this driver as a module, choose M here.  The module
> +	  will be called atl1.
> +
> +
>  endmenu

One problem here is that MII depends on NET_ETHERNET, which is
10/100 ethernet, which may not be enabled if someone has only
gigabit ethernet.  :)

I have a partial patch which moves MII and PHYLIB outside of
NET_ETHERNET.  That also makes them usable by USB or other
non-drivers/net/ drivers, e.g., again without the need
to enable NET_ETHERNET if someone only has USB ethernet.  :(

I'll try to post it for review later today.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/