linux-kernel - Re: reiserfs NET=n build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45608FC2.5040406@suse.com>
Date:	Sun, 19 Nov 2006 12:09:22 -0500
From:	Jeff Mahoney <jeffm@...e.com>
To:	Andi Kleen <ak@...e.de>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	lkml <linux-kernel@...r.kernel.org>, reiserfs-dev@...esys.com,
	sam@...nborg.org, Al Viro <viro@....linux.org.uk>
Subject: Re: reiserfs NET=n build error

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andi Kleen wrote:
> On Sunday 19 November 2006 05:22, Randy Dunlap wrote:
>> With CONFIG_NET=n and REISERFS_FS=m (randconfig), kernel build ends with
>>
>> Kernel: arch/x86_64/boot/bzImage is ready  (#15)
>>   Building modules, stage 2.
>>   MODPOST 137 modules
>> WARNING: "csum_partial" [fs/reiserfs/reiserfs.ko] undefined!
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>>
>> on both 2.6.19-rc6 and 2.6.19-rc6-git2.
>>
>> Looks like arch/x86_64/lib/lib.a is not being linked into the
>> final kernel image for some reason.  lib.a does contain csum_partial.
> 
> iirc Al Viro has been cleaning that up. Essentially reiserfs should
> use its own C copy of the checksum functions. Using csum_partial() is not
> safe because its output varies by architecture.
> 
> I would copy a relatively simple C implementation, like arch/h8300/lib/checksum.c

As long as the h8300 version has the same output as the x86 version.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFFYI/BLPWxlyuTD7IRAjveAJ0U+D3PO6h+2z83ZG9ZLay3q5JBFACcDHFQ
hIaiIBCFzfHg9qak9cxUtRo=
=GuqM
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/