linux-kernel - Re: [PATCH] PCMCIA identification strings for cards manufactured by Elan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1164027086.31358.588.camel@laptopd505.fenrus.org>
Date:	Mon, 20 Nov 2006 13:51:25 +0100
From:	Arjan van de Ven <arjan@...radead.org>
To:	Tony Olech <tony.olech@...ndigitalsystems.com>
Cc:	Dominik Brodowski <linux@...inikbrodowski.net>,
	Linux kernel development <linux-kernel@...r.kernel.org>,
	PCMCIA Maintainence <linux-pcmcia@...ts.infradead.org>,
	David Hinds <dahinds@...rs.sourceforge.net>,
	Jaroslav Kysela <perex@...e.cz>,
	Bart Prescott <bart.prescott@...ndigitalsystems.com>
Subject: Re: [PATCH] PCMCIA identification strings for cards manufactured
	by Elan

Hi,

> a card is inserted, resulting in various random lockups
> 
> *** linux-2.6.18/sound/pcmcia/pdaudiocf/pdaudiocf.c.orig	2006-11-20 10:24:23.000000000 +0000
> --- linux-2.6.18/sound/pcmcia/pdaudiocf/pdaudiocf.c	2006-11-20 10:33:46.000000000 +0000
> ***************
> *** 298,306 ****
>   /*
>    * Module entry points
>    */
>   static struct pcmcia_device_id snd_pdacf_ids[] = {
> ! 	PCMCIA_DEVICE_MANF_CARD(0x015d, 0x4c45),


please use the "-u" option for diff; that's the preferred (only) form
the Linux kernel folks are used to looking at diffs, and applying them.
Also, it's very helpful and customary to also pass the "-p" option (this
improves the context so that reviews are easier)

would you mind redoing the diff and then resending it?

Thanks!


-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/