linux-kernel - Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061120100202.6a79e382@freekitty>
Date:	Mon, 20 Nov 2006 10:02:02 -0800
From:	Stephen Hemminger <shemminger@...l.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Chris Snook <csnook@...hat.com>,
	Jay Cliburn <jacliburn@...lsouth.net>, jeff@...zik.org,
	romieu@...zoreil.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver

On Mon, 20 Nov 2006 13:21:59 +0100
Arnd Bergmann <arnd@...db.de> wrote:

> On Monday 20 November 2006 07:12, Chris Snook wrote:
> > > 
> > > Any reason why you can't use generic_mii_ioctl?
> > 
> > I decided to mostly leave this code alone, in the hope that we could 
> > just rip out MII support entirely and nobody would mind.  What do you think?
> > 
> 
> Normally, I think you should just implement mdio_read/mdio_write functions
> and then use all the helpers from drivers/net/mii.c to implement mii_ioctl
> and other functions like ethtool_gset.
> 
> 	Arnd <><
> 

Using common MII code is good, but one problem with the existing MII code is that
it doesn't work when device is down. This makes it impossible to set speed/duplex
before device comes up.

-- 
Stephen Hemminger <shemminger@...l.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/