linux-kernel - Re: [Patch -mm 2/2] driver core: Introduce device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061120090537.6d59dbc5@gondolin.boeblingen.de.ibm.com>
Date:	Mon, 20 Nov 2006 09:05:37 +0100
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Greg KH <greg@...ah.com>
Cc:	Kay Sievers <kay.sievers@...y.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: Re: [Patch -mm 2/2] driver core: Introduce device_move(): move a
 device to a new parent.

On Thu, 16 Nov 2006 20:23:38 -0800,
Greg KH <greg@...ah.com> wrote:

> On Thu, Nov 16, 2006 at 05:47:37PM +0100, Kay Sievers wrote:
> > On Thu, 2006-11-16 at 15:42 +0100, Cornelia Huck wrote:
> > > From: Cornelia Huck <cornelia.huck@...ibm.com>
> > > 
> > > Provide a function device_move() to move a device to a new parent device. Add
> > > auxilliary functions kobject_move() and sysfs_move_dir().
> > > kobject_move() generates a new uevent of type KOBJ_MOVE, containing the
> > > previous path (OLD_DEVPATH) in addition to the usual values.
> > 
> > > +	sprintf(devpath_string, "OLD_DEVPATH=%s", devpath);
> > 
> > I think it's easier to understand, if the variable starts with the same
> > string as original name. I prefer DEVPATH_OLD.
> > 
> > > +void kobject_uevent_extended(struct kobject *kobj, enum kobject_action action,
> > > +			     const char *string)
> > 
> > I think we should pass an array of env vars here instead of a single
> > string - you never know ... :) The function could probably be named
> > kobject_uevent_env() then.
> 
> I agree, care to respin these?

OK, makes sense. I'll post a new one today.

-- 
Cornelia Huck
Linux for zSeries Developer
Tel.: +49-7031-16-4837, Mail: cornelia.huck@...ibm.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/