linux-kernel - Re: [patch 1/2] fix call to alloc_bootmem after bootmem has been freed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061121102616.47d03ccc.akpm@osdl.org>
Date:	Tue, 21 Nov 2006 10:26:16 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Christian Krafft <krafft@...ibm.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 1/2] fix call to alloc_bootmem after bootmem has been
 freed

On Tue, 21 Nov 2006 19:02:13 +0100
Christian Krafft <krafft@...ibm.com> wrote:

> > > Index: linux/mm/page_alloc.c
> > > ===================================================================
> > > --- linux.orig/mm/page_alloc.c
> > > +++ linux/mm/page_alloc.c
> > > @@ -1931,7 +1931,7 @@ int zone_wait_table_init(struct zone *zo
> > >  	alloc_size = zone->wait_table_hash_nr_entries
> > >  					* sizeof(wait_queue_head_t);
> > >
> > > - 	if (system_state == SYSTEM_BOOTING) {
> > > +	if (!slab_is_available()) {
> > >  		zone->wait_table = (wait_queue_head_t *)
> > >  			alloc_bootmem_node(pgdat, alloc_size);
> > >  	} else {
> > 
> > I don't think that slab_is_available() is an appropriate way of working out
> > if we can call vmalloc().
> 
> Afaik slab_is_available() is the generic replacement for mem_init_done, which exists only on powerpc. 
> If thats not appropriate, I dont know why. However, SYSTEM_BOOTING is definitively wrong.

slab is a very different thing from vmalloc.  One could easily envisage
situations (now or in the future) in which slab is ready, but vmalloc is
not (more likely vice versa).

It'd be better to add a new vmalloc_is_available.  (Just an int - no need
for a helper function).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/