linux-kernel - [PATCH] add return value checking of get_user() in set_vesa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061121141528.234a9335.yoichi_yuasa@tripeaks.co.jp>
Date:	Tue, 21 Nov 2006 14:15:28 +0900
From:	Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
To:	Andrew Morton <akpm@...l.org>
Cc:	yoichi_yuasa@...peaks.co.jp,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [PATCH] add return value checking of get_user() in
 set_vesa_blanking()

Hi,

This patch has added return value checking of get_user() in set_vesa_blanking().

Yoichi

Signed-off-by: Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
 
diff -pruN -X generic/Documentation/dontdiff generic-orig/drivers/char/vt.c generic/drivers/char/vt.c
--- generic-orig/drivers/char/vt.c	2006-11-21 10:23:39.409667250 +0900
+++ generic/drivers/char/vt.c	2006-11-21 10:11:48.037209250 +0900
@@ -3318,9 +3318,10 @@ postcore_initcall(vtconsole_class_init);
 
 static void set_vesa_blanking(char __user *p)
 {
-    unsigned int mode;
-    get_user(mode, p + 1);
-    vesa_blank_mode = (mode < 4) ? mode : 0;
+	unsigned int mode;
+
+	if (!get_user(mode, p + 1))
+		vesa_blank_mode = (mode < 4) ? mode : 0;
 }
 
 void do_blank_screen(int entering_gfx)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/