linux-kernel - Re: [PATCH 17/22] coredump: Add SPU elf notes to coredump.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1164087488.13318.43.camel@localhost.localdomain>
Date:	Tue, 21 Nov 2006 16:38:08 +1100
From:	Michael Ellerman <michael@...erman.id.au>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	cbe-oss-dev@...abs.org, linux-arch@...r.kernel.org,
	Arnd Bergmann <arnd.bergmann@...ibm.com>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
	Paul Mackerras <paulus@...ba.org>,
	Dwayne Grant McConnell <decimal@...ibm.com>
Subject: Re: [PATCH 17/22] coredump: Add SPU elf notes to coredump.

On Mon, 2006-11-20 at 18:45 +0100, Arnd Bergmann wrote:
> Index: linux-2.6/include/linux/elf.h
> ===================================================================
> --- linux-2.6.orig/include/linux/elf.h
> +++ linux-2.6/include/linux/elf.h
> @@ -368,5 +368,12 @@ extern Elf64_Dyn _DYNAMIC [];
>  
>  #endif
>  
> +#ifndef ARCH_HAVE_EXTRA_ELF_NOTES
> +static inline int arch_notes_size(void) { return 0; }
> +static inline int arch_write_notes(void) { return 0; }
> +
> +#define ELF_CORE_EXTRA_NOTES_SIZE arch_notes_size()
> +#define ELF_CORE_WRITE_EXTRA_NOTES arch_write_notes(file)
> +#endif /* ARCH_HAVE_EXTRA_ELF_NOTES */

This is broken for !CELL. arch_write_notes(void) can't be called as
arch_write_notes(file).

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)