linux-kernel - Re: [RFC] [PATCH] Fix misrouted interrupts deadlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4562B476.801@sw.ru>
Date:	Tue, 21 Nov 2006 11:10:30 +0300
From:	Pavel Emelianov <xemul@...ru>
To:	vgoyal@...ibm.com, mingo@...hat.com
CC:	Andrew Morton <akpm@...l.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kirill Korotaev <dev@...nvz.org>
Subject: Re: [RFC] [PATCH] Fix misrouted interrupts deadlocks

> Hi Pavel,
> 
> If I backout your changes, everything works fine. So it looks like that
> the problem I am facing is because of your patch but I don't have a logical
> explanation yet that why the problem is there. Just realasing a lock
> which is not currently acquired should not hang the system?

Hm... A simple grep over the code showed that note_interrupt
is called w/o desc->lock in all places but __do_IRQ(). And this
looks like an error at least for the following reason:
note_interrupt() calls __report_bad_irq() and __report_bad_irq()
does require desc->lock to be held. So I suppose that we have
to do spin_lock(&desc->lock) before calling note_interrupt().
I'll prepare a patch in a moment.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/