linux-kernel - Re: [PATCH take 2] Atmel MACB ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58L.0611220918170.4718@toxygen.net>
Date:	Wed, 22 Nov 2006 13:50:20 +0100 (CET)
From:	Wojtek Kaniewski <wojtekka@...ygen.net>
To:	Haavard Skinnemoen <hskinnemoen@...el.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH take 2] Atmel MACB ethernet driver

On Fri, 17 Nov 2006, Haavard Skinnemoen wrote:
> Hmm...underruns as in "eth0: TX underrun, resetting buffers"?

Yes, that's the message.

> (...)
> 
> If it's a problem with the descriptor, it would probably help to dump
> out some information about the ring state, i.e. the value of
> bp->tx_head and bp->tx_tail, and maybe dump all outstanding descriptors
> in the ring to see if any of them look suspicious.

I've added some printk()s in underrun handler. There's still some data
in the ring (tail=29, head=32), so the driver seems okay. The list of
descriptors:

  tx_ring[28].ctrl=0x8000850e (used=1 wrap=0 und=0 last=1)
  tx_ring[29].ctrl=0x900085ea (used=1 wrap=0 und=1 last=1) TAIL
  tx_ring[30].ctrl=0x000085ea (used=0 wrap=0 und=0 last=1)
  tx_ring[31].ctrl=0x0000850e (used=0 wrap=0 und=0 last=1)
  tx_ring[32].ctrl=0x800085ea (used=1 wrap=0 und=0 last=1) HEAD
  tx_ring[33].ctrl=0x8000850e (used=1 wrap=0 und=0 last=1)

Buffer addresses look fine, tx_ring[29..32].addr don't differ much from
the rest. 

> If it's a bus latency issue, things start to get a bit
> platform-specific, so we should probably involve some more experienced
> ARM people.

Looks like I'll have to wait for upstream support of 9260, because I'm
new to ARM and I won't handle it by myself. Anyway thanks for your help.

Regards,
Wojtek
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/