linux-kernel - Re: arch/x86_64/mm/numa.c(124): remark #593: variable "bootmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0611221319340.23776@skynet.skynet.ie>
Date:	Wed, 22 Nov 2006 13:29:44 +0000 (GMT)
From:	Mel Gorman <mel@....ul.ie>
To:	Andi Kleen <ak@...e.de>
Cc:	d binderman <dcb314@...mail.com>, linux-kernel@...r.kernel.org
Subject: Re: arch/x86_64/mm/numa.c(124): remark #593: variable "bootmap_size"
 was set but nev

On Wed, 22 Nov 2006, Andi Kleen wrote:

> "d binderman" <dcb314@...mail.com> writes:
>
>> Hello there,
>>
>> I just tried to compile Linux kernel 2.6.18.3 with the Intel C
>> C compiler.
>>
>> The compiler said
>>
>> arch/x86_64/mm/numa.c(124): remark #593: variable "bootmap_size" was
>> set but never used
>
> Actually it looks like a real bug -- probably added recently with the
> new bootmap code.
>
> The bootmap should be reserved based on that size.
>

I checked the arch-independent sizing patches submitted related to x86_64 
and no line is changed that does anything with bootmap_size so that ruled 
out an obvious candidate. I did a diff on a grep for bootmap_size in 
arch/x86_64 and found that there is no difference in usage between 2.6.18 
and 2.6.19-rc6. Both call reserve_bootmem(bootmap, bootmap_size) which has 
changed. However, the changes seem to be more cosmetic than anything else 
using PFN_DOWN and PFN_UP instead of some_value/PAGE_SIZE so it's not 
super-clear where the warning is coming from.

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/