linux-kernel - Re: [Patch -mm 2/2] driver core: Introduce device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0611221236090.3913-100000@iolanthe.rowland.org>
Date:	Wed, 22 Nov 2006 12:37:42 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
cc:	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [Patch -mm 2/2] driver core: Introduce device_move(): move a
 device

On Wed, 22 Nov 2006, Cornelia Huck wrote:

> On Wed, 22 Nov 2006 10:32:47 -0500 (EST),
> Alan Stern <stern@...land.harvard.edu> wrote:

> > I don't see any protection against new_parent being removed while dev is
> > being transferred under it.  Are you relying on the caller to make sure
> > this never happens?
> 
> Is there any mechanism in the driver core to avoid such races? The only
> locking I can see are klists and dev->sem (which only protects
> probing). AFAICS, the caller needs to ensure consistency anyway (like
> with the subchannel mutex we introduced in s390 to ensure device
> register and unregister cannot be called concurrently).

Generally the driver core does rely on callers to handle these things.
I just wanted to make sure you were aware of the issue.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/