linux-kernel - Re: [PATCH] ieee1394: nodemgr: fix deadlock in shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0611212028160.5677-100000@netrider.rowland.org>
Date:	Tue, 21 Nov 2006 21:02:57 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
cc:	linux1394-devel@...ts.sourceforge.net,
	Greg Kroah-Hartman <gregkh@...e.de>,
	<linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dtor@...ightbb.com>
Subject: Re: [PATCH] ieee1394: nodemgr: fix deadlock in shutdown

On Tue, 21 Nov 2006, Stefan Richter wrote:

> There is now a /sys/bus/ieee1394/drivers/ieee1394, whose "bind" and
> "unbind" attributes are not welcome.  Is there a way to disable them?

You can always prevent "bind" from operating by returning an error code
from the driver's probe routine (although it's not clear why you would
want to do that).  I don't think there's any way to make the "unbind"
attribute stop working.

You could violate the layering and remove the attribute files directly.  
But that would be a race; there would remain a brief interval between the 
time the files were created and the time you removed them.

Lastly, you could remove source of your deadlock by having the unbind 
routine for the new driver delete all the child device structures.  In 
fact, just to make things more symmetric and logical you could have the 
probe routine create those child devices in the first place!

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/