linux-kernel - Re: [PATCH] Disable INTx when enabling MSI in forcedeth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0611212147100.20138@iabervon.org>
Date:	Tue, 21 Nov 2006 21:53:01 -0500 (EST)
From:	Daniel Barkalow <barkalow@...ervon.org>
To:	Linus Torvalds <torvalds@...l.org>
cc:	linux-kernel@...r.kernel.org, Jeff Garzik <jeff@...zik.org>,
	David Miller <davem@...emloft.net>,
	Roland Dreier <rdreier@...co.com>,
	Ayaz Abdulla <aabdulla@...dia.com>
Subject: Re: [PATCH] Disable INTx when enabling MSI in forcedeth

On Tue, 21 Nov 2006, Linus Torvalds wrote:

> On Tue, 21 Nov 2006, Daniel Barkalow wrote:
> >
> > My nVidia ethernet card doesn't disable its own INTx when MSI is
> > enabled. This causes a steady stream of spurious interrupts that
> > eventually kills my SATA IRQ if MSI is used with forcedeth, which is
> > true by default. Simply disabling the INTx interrupt takes care of it.
> > 
> > This is against -stable, and would be suitable once someone who knows the 
> > code verifies that it's correct.
> 
> I _really_ think that we should do this in pci_msi_enable().
>
> Screw cards that are not PCI-2.3 compliant - just make the rule be that if 
> you use MSI, you _have_ to allow us to set the disable-INTx bit. It's then 
> up to the drivers to decide if they can use MSI or not.
> 
> (Even a number of cards that are not PCI-2.3 may simply not _implement_ 
> the disable-INTx bit, and in that case, they can use MSI if they disable 
> INTx automatically - the ).
> 
> Comments?

I think that's the right thing to do, but I bet it'll break systems until 
the drivers are up to date. So I'd wait until 2.6.20 to do it that way, 
but definitely do it that way then.

	-Daniel
*This .sig left intentionally blank*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/