linux-kernel - Re: [PATCH] fix random SD/MMC card recognition failures on ARM Versatile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061123160335.GB8984@flint.arm.linux.org.uk>
Date:	Thu, 23 Nov 2006 16:03:35 +0000
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Vitaly Wool <vitalywool@...il.com>
Cc:	drzeus-mmc@...eus.cx, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fix random SD/MMC card recognition failures on ARM Versatile

On Thu, Nov 23, 2006 at 06:46:06PM +0300, Vitaly Wool wrote:
> Hello Pierre,
> 
> currently sometimes the SD/MMC card inserted results in recognition failure on ARM Versatile board:
> 
>    <<<Plug in MMC card>>>
> 
> root@...satile:~# mmcblk0: mmc0:0001 SDMB-32 31360KiB
>  mmcblk0:<3>mmcblk0: error 3 transferring data
> end_request: I/O error, dev mmcblk0, sector 0
> Buffer I/O error on device mmcblk0, logical block 0
> mmcblk0: error 3 transferring data
> end_request: I/O error, dev mmcblk0, sector 0
> Buffer I/O error on device mmcblk0, logical block 0
>  unable to read partition table
> 
> This patch fixes the problem.

Doubtful.  mmci_stop_data() already does this, which will be called
immediately prior to mmci_request_end().  So you're doubling up the
writes to registers again.

Since this is not the first occurance that you've had to do this with
your board (the other being the SIC) I suggest that your board is
faulty in some way, causing writes to registers to be occasionally
dropped.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/