linux-kernel - Re: [PATCH -mm 3/4][AIO] - AIO completion signal notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061123092433.1d2b9c95@frecb000686>
Date:	Thu, 23 Nov 2006 09:24:33 +0100
From:	Sébastien Dugué <sebastien.dugue@...l.net>
To:	Zach Brown <zach.brown@...cle.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-aio <linux-aio@...ck.org>, Andrew Morton <akpm@...l.org>,
	Suparna Bhattacharya <suparna@...ibm.com>,
	Christoph Hellwig <hch@...radead.org>,
	Badari Pulavarty <pbadari@...ibm.com>,
	Jean Pierre Dion <jean-pierre.dion@...l.net>,
	Ulrich Drepper <drepper@...hat.com>
Subject: Re: [PATCH -mm 3/4][AIO] - AIO completion signal notification

On Wed, 22 Nov 2006 02:22:15 -0800
Zach Brown <zach.brown@...cle.com> wrote:

> >   OK, looking at this, there's something bothering me: io_submit_one() needs
> > a pointer to the user iocb in order to push back the iocb->ki_key to userspace,
> > as well as storing the user_iocb pointer into iocb->ki_obj.
> 
> Why can't it continue to do what it does today?  Both of those uses of
> the user_iocb pointer involve fixed-width fields and don't need compat help.

  Aah, right, thanks.

> 
> >   So I think that some of the logic in io_submit_one() must be moved up to
> > sys_io_submit(), including the aio_get_req() call.
> 
> I don't see why that would be needed.

  Not anymore, indeed.


  Thanks,

  Sébastien.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/