linux-kernel - [PATCH] x86_64 vsyscall fails to compile when CONFIG_HOTPLUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e605df1da2b2e35ab69e8167c2b71b7f@pinky>
Date:	Fri, 24 Nov 2006 17:58:01 +0000
From:	Andy Whitcroft <apw@...dowen.org>
To:	Andrew Morton <akpm@...l.org>
Cc:	Andy Whitcroft <apw@...dowen.org>, Andi Kleen <ak@...e.de>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] x86_64 vsyscall fails to compile when CONFIG_HOTPLUG_CPU is disabled

x86_64 vsyscall fails to compile when CONFIG_HOTPLUG_CPU is disabled

The following change attempted to fix up the notifier structure
when CONFIG_HOTPLUG_CPU is disabled:

    [PATCH] x86-64: Fix vgetcpu when CONFIG_HOTPLUG_CPU is disabled

It seems to leave a reference to the cpu_vsyscall_notifier which is
not declared unles CONFIG_HOTPLUG_CPU is defined, leading to the following
compile time error:

  arch/x86_64/kernel/vsyscall.c:310: error: `cpu_vsyscall_notifier'
				  undeclared (first use in this function)

Make the hotcpu_notifier dependant on CONFIG_HOTPLUG_CPU.

Signed-off-by: Andy Whitcroft <apw@...dowen.org>
---
diff --git a/arch/x86_64/kernel/vsyscall.c b/arch/x86_64/kernel/vsyscall.c
index 3416462..e93ffcf 100644
--- a/arch/x86_64/kernel/vsyscall.c
+++ b/arch/x86_64/kernel/vsyscall.c
@@ -307,7 +307,9 @@ static int __init vsyscall_init(void)
 	register_sysctl_table(kernel_root_table2, 0);
 #endif
 	on_each_cpu(cpu_vsyscall_init, NULL, 0, 1);
+#ifdef CONFIG_HOTPLUG_CPU
 	hotcpu_notifier(cpu_vsyscall_notifier, 0);
+#endif
 	return 0;
 }
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/