linux-kernel - Re: [patch] cpufreq: mark cpufreq_tsc() as core_initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061124211300.GA102@oleg>
Date:	Sat, 25 Nov 2006 00:13:00 +0300
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	"Paul E. McKenney" <paulmck@...ibm.com>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] cpufreq: mark cpufreq_tsc() as core_initcall_sync

On 11/24, Alan Stern wrote:
>
> On Fri, 24 Nov 2006, Oleg Nesterov wrote:
> 
> > Ok, synchronize_xxx() passed 1 hour rcutorture test on dual P-III.
> > 
> > It behaves the same as srcu but optimized for writers. The fast path
> > for synchronize_xxx() is mutex_lock() + atomic_read() + mutex_unlock().
> > The slow path is __wait_event(), no polling. However, the reader does
> > atomic inc/dec on lock/unlock, and the counters are not per-cpu.
> > 
> > Jens, is it ok for you? Alan, Paul, what is your opinion?
> 
> Given that you aren't using per-cpu data, why not just rely on a spinlock?

I thought about this too, and we can re-use sp->wq.lock,

> Then everything will be simple and easy to verify,

xxx_read_lock() will be simpler, but not too much. synchronize_xxx() needs
some complication.

>                                                     with no need to worry 
> about atomic instructions or memory barriers.

spin_lock() + spin_unlock() doesn't imply mb(), it allows subsequent loads
to move into the the critical region.

I personally prefer this way, but may be you are right.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/