linux-kernel - Re: [PATCH] 6pack: fix "&= !" typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061124214218.GA13168@linux-mips.org>
Date:	Fri, 24 Nov 2006 21:42:18 +0000
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Willy Tarreau <w@....eu>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Andreas Koensgen <ajk@...k.rwth-aachen.de>,
	linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: [PATCH] 6pack: fix "&= !" typo

On Fri, Nov 24, 2006 at 10:23:06PM +0100, Willy Tarreau wrote:

> One more reason to perform more code reviews helped with automated tools.
> We found this one and the rio's one while discussing with Jean Delvare
> about such bugs, and firing a random grep to illustrate how easy it could
> be to spot bugs similar to Alexey's "&&" instead of "&" ...
> 
> I think that we should at least take a look at all lines in the pre-processed
> code having both '!' and '&' on the same line. There are a lot of them, but
> divided by a sufficient number of volunteers, we might catch a bunch of them.
> 
> BTW, has anyone a good idea on how to make gcc dump the preprocessed files
> for everything it builds ? I mean, just by changing some variables in the
> Makefile.

It seems to might be about to re-invent sparse which is probably the
right framework for such semantic tests.

  Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/