[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20061124231112.GA5781@ccure.user-mode-linux.org>
Date: Fri, 24 Nov 2006 18:11:12 -0500
From: Jeff Dike <jdike@...toit.com>
To: Andrew Morton <akpm@...l.org>
Cc: linux-kernel@...r.kernel.org, blaisorblade@...oo.it
Subject: Re: + uml-make-execvp-safe-for-our-usage.patch added to -mm tree
On Fri, Nov 24, 2006 at 01:46:21PM -0800, Andrew Morton wrote:
> OK. Is it needed for 2.6.19?
It fixes bugs, so I would say yes.
> Also, I'm still sitting on the below. I have a note that you nacked it,
> but I forget why.
I nacked it mostly based on the changelog, which turned out to be
incorrect. The substance of the change I think is OK, except that it
looks like stddef (according to the C standard - 4.1.5) , not
linux/types is the official way to get size_t. I'll send a follow-up
patch to fix that.
I would hold this patch until after 2.6.19.
Jeff
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists