linux-kernel - Re: sx1 mixer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hac2hf169.wl%tiwai@suse.de>
Date:	Fri, 24 Nov 2006 14:02:06 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Pavel Machek <pavel@....cz>
Cc:	Tony Lindgren <tony@...mide.com>,
	kernel list <linux-kernel@...r.kernel.org>,
	Vladimir Ananiev <vovan888@...il.com>,
	linux-omap <linux-omap-open-source@...ux.omap.com>
Subject: Re: sx1 mixer support

At Fri, 24 Nov 2006 13:50:40 +0100,
Pavel Machek wrote:
> 
> > > + * Defines codec specific functions pointers that can be used from the
> > > + * common omap-alsa base driver for all omap codecs.
> > > + */
> > > +void egold_configure(void);
> > > +void egold_set_samplerate(long rate);
> > > +void egold_clock_setup(void);
> > > +int egold_clock_on(void);
> > > +int egold_clock_off(void);
> > > +int egold_get_default_samplerate(void);
> > 
> > Do they need to be exported?  I see them only in a single file as
> > callbacks...
> 
> Apparently they do not. Fixed.

They are still globals.  Could be static, right?


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/