| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20061125212440.GA5930@1wt.eu> Date: Sat, 25 Nov 2006 22:24:40 +0100 From: Willy Tarreau <w@....eu> To: shaggy@...tin.ibm.com Cc: linux-kernel@...r.kernel.org Subject: [PATCH-2.4] jfs: incorrect use of "&&" instead of "&" Hi Dave, I'm about to merge this fix in 2.4. It's already in 2.6 BTW. Do you have any objection ? Thanks in advance, Willy >From b14cb91c6621908f8e957aad5a85d6c41b31dfea Mon Sep 17 00:00:00 2001 From: Willy Tarreau <w@....eu> Date: Sat, 25 Nov 2006 21:57:26 +0100 Subject: [PATCH] jfs: incorrect use of "&&" instead of "&" in jfs_txnmgr, the use of "tblk->flag && COMMIT_DELETE" in a if() condition is obviously wrong. This bug has already been fixed in 2.6. Signed-off-by: Willy Tarreau <w@....eu> --- fs/jfs/jfs_txnmgr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c index 62e6493..4e6a280 100644 --- a/fs/jfs/jfs_txnmgr.c +++ b/fs/jfs/jfs_txnmgr.c @@ -1175,7 +1175,7 @@ int txCommit(tid_t tid, /* transaction jfs_ip = JFS_IP(ip); if (test_and_clear_cflag(COMMIT_Syncdata, ip) && - ((tblk->flag && COMMIT_DELETE) == 0)) + ((tblk->flag & COMMIT_DELETE) == 0)) fsync_inode_data_buffers(ip); /* -- 1.4.2.4 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists