linux-kernel - Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061125.150500.14841768.davem@davemloft.net>
Date:	Sat, 25 Nov 2006 15:05:00 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	rdreier@...co.com
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org,
	openib-general@...nib.org, tom@...ngridcomputing.com
Subject: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

From: Roland Dreier <rdreier@...co.com>
Date: Sat, 25 Nov 2006 14:56:22 -0800

>  > Perhaps a better way to fix this is to use
>  > typeof() like other similar macros do.
> 
> I tried doing
> 
> #define ALIGN(x,a)				\
> 	({					\
> 		typeof(x) _a = (a);		\
> 		((x) + _a - 1) & ~(_a - 1);	\
> 	})
> 
> but that won't compile because of <net/neighbour.h>:

You would need to also cast the constants with typeof() to.

But yes, given the array sizing case in the neighbour code,
perhaps we can use your original patch for now.  Feel free
to push that to Linus.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/