linux-kernel - Re: [2.6 patch] net/sctp/socket.c: add missing sctp_spin_unlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45698AA3.1020601@redhat.com>
Date:	Sun, 26 Nov 2006 20:37:55 +0800
From:	Eugene Teo <eteo@...hat.com>
To:	Al Viro <viro@....linux.org.uk>
CC:	lksctp-developers@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] net/sctp/socket.c: add missing sctp_spin_unlock_irqrestore

Al Viro wrote:
> On Sun, Nov 26, 2006 at 06:00:53PM +0800, Eugene Teo wrote:
>> This patch adds a missing sctp_spin_unlock_irqrestore when returning
>> from "if(space_left<addrlen)" condition.
>>                 if (copy_to_user(*to, &temp, addrlen)) {
>> -                       sctp_spin_unlock_irqrestore(&sctp_local_addr_lock,
>> -                                                   flags);
>> -                       return -EFAULT;
>> +                       err = -EFAULT;
>> +                       goto unlock;
> 
>> +       sctp_spin_unlock_irqrestore(&sctp_local_addr_lock, flags);
>> +       return err;
>>  }
> 
> You do realize that it's obviously still badly broken, don't you?
> copy_to_user() under a spinlock is a recipe for deadlock, especially
> if you've got interrupts disabled...

Realized. Back to drawing board.

Eugene
-- 
1024D/58DF8823 print 47B9 90F6 AE4A 9C51 37E0  D6E1 EA84 C6A2 58DF 8823
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/