linux-kernel - Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061126011014.GR3078@ftp.linux.org.uk>
Date:	Sun, 26 Nov 2006 01:10:14 +0000
From:	Al Viro <viro@....linux.org.uk>
To:	David Miller <davem@...emloft.net>
Cc:	rdreier@...co.com, akpm@...l.org, linux-kernel@...r.kernel.org,
	openib-general@...nib.org, tom@...ngridcomputing.com
Subject: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

On Sat, Nov 25, 2006 at 03:05:00PM -0800, David Miller wrote:
> From: Roland Dreier <rdreier@...co.com>
> Date: Sat, 25 Nov 2006 14:56:22 -0800
> 
> >  > Perhaps a better way to fix this is to use
> >  > typeof() like other similar macros do.
> > 
> > I tried doing
> > 
> > #define ALIGN(x,a)				\
> > 	({					\
> > 		typeof(x) _a = (a);		\
> > 		((x) + _a - 1) & ~(_a - 1);	\
> > 	})
> > 
> > but that won't compile because of <net/neighbour.h>:
> 
> You would need to also cast the constants with typeof() to.

Oh, for fsck sake...

	(typeof(x))((x + a - 1) & ~(a - 1ULL))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/