linux-kernel - Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061126012511.GS3078@ftp.linux.org.uk>
Date:	Sun, 26 Nov 2006 01:25:11 +0000
From:	Al Viro <viro@....linux.org.uk>
To:	Roland Dreier <rdreier@...co.com>
Cc:	David Miller <davem@...emloft.net>, akpm@...l.org,
	linux-kernel@...r.kernel.org, openib-general@...nib.org,
	tom@...ngridcomputing.com
Subject: Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

On Sat, Nov 25, 2006 at 05:17:08PM -0800, Roland Dreier wrote:
>  > 	(typeof(x))((x + a - 1) & ~(a - 1ULL))
> 
> Yes I was being stupid thinking I needed a temporary variable to use
> typeof.  But what does the cast to typeof(x) accomplish if we write
> things the way you suggested above?  It seems that the right things is
> really just
> 
> 	(((x) + (a) - 1) & ~((typeof(x)) (a) - 1))

Better have type of result independent of that of a.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/