linux-kernel - Re: [PATCH 19/38] KVM: Make __set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Nov 2006 13:39:44 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Avi Kivity <avi@...ranet.com>
Cc:	kvm-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	akpm@...l.org
Subject: Re: [PATCH 19/38] KVM: Make __set_efer() an arch operation

On Mon, Nov 27, 2006 at 12:29:38PM -0000, Avi Kivity wrote:
>  #ifdef __x86_64__
> -	__set_efer(vcpu, sregs->efer);
> +	kvm_arch_ops->set_efer(vcpu, sregs->efer);
>  #endif

I think it would be much better to make ->set_efer a noop for 32bit,
and have different operation vectors for 32 vs 64 bit.

>  #ifdef __x86_64__
> -	__set_efer(vcpu, 0);
> +	vmx_set_efer(vcpu, 0);
>  #endif

Similarly vmx_set_efer should just become a noop on 32bit.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/