[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20061127045407.GA1231@APFDCB5C>
Date: Mon, 27 Nov 2006 13:54:07 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: linux-kernel@...r.kernel.org
Cc: David Woodhouse <dwmw2@...radead.org>
Subject: [PATCH] audit: fix kstrdup() error check
kstrdup() returns NULL on error.
Cc: David Woodhouse <dwmw2@...radead.org>
Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
---
kernel/auditfilter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: work-fault-inject/kernel/auditfilter.c
===================================================================
--- work-fault-inject.orig/kernel/auditfilter.c
+++ work-fault-inject/kernel/auditfilter.c
@@ -800,8 +800,8 @@ static inline int audit_dupe_selinux_fie
/* our own copy of se_str */
se_str = kstrdup(sf->se_str, GFP_KERNEL);
- if (unlikely(IS_ERR(se_str)))
- return -ENOMEM;
+ if (unlikely(!se_str))
+ return -ENOMEM;
df->se_str = se_str;
/* our own (refreshed) copy of se_rule */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists