linux-kernel - Re: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <456B7573.1050200@garzik.org>
Date:	Mon, 27 Nov 2006 18:32:03 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Andrew Morton <akpm@...l.org>
CC:	Robert Hancock <hancockr@...w.ca>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org, Nicolas.Mailhot@...oste.net
Subject: Re: [PATCH -mm] sata_nv: fix ATAPI in ADMA mode

Andrew Morton wrote:
> On Sun, 26 Nov 2006 14:20:19 -0600
> Robert Hancock <hancockr@...w.ca> wrote:
> 
>>  static irqreturn_t nv_adma_interrupt(int irq, void *dev_instance)
>>  {
>>  	struct ata_host *host = dev_instance;
>>  	int i, handled = 0;
>> +	u32 notifier_clears[2];
>>  
>>  	spin_lock(&host->lock);
>>  
>>  	for (i = 0; i < host->n_ports; i++) {
>>  		struct ata_port *ap = host->ports[i];
>> +		notifier_clears[i] = 0;
> 
> Promise us that n_ports will never exceed 2?

ADMA spec is only defined for two channels, at least.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/