linux-kernel - Re: [Patch 3/7] driver core fixes: device_register() retval check in platform.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061127112447.GA28761@flint.arm.linux.org.uk>
Date:	Mon, 27 Nov 2006 11:24:47 +0000
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
Cc:	Greg K-H <greg@...ah.com>, Andrew Morton <akpm@...l.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Patch 3/7] driver core fixes: device_register() retval check in platform.c

On Mon, Nov 27, 2006 at 10:35:08AM +0100, Cornelia Huck wrote:
> From: Cornelia Huck <cornelia.huck@...ibm.com>
> 
> Check the return value of device_register() in platform_bus_init().

I still say this is absolutely crazy.  If a bus does not get registered,
what happens to all the devices and drivers which are registered against
that bus?

I suspect that if this bus_register doesn't work, you'll see an oops
sooner or later.  So it might as well be a BUG_ON here.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/