linux-kernel - [PATCH] ext3: small fix for previous retries patch in ext3_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 28 Nov 2006 19:29:47 +0300
From:	Kirill Korotaev <dev@...nvz.org>
To:	Andrew Morton <akpm@...l.org>, sct@...hat.com,
	linux-kernel@...r.kernel.org, saw@...ru, adilger@...sterfs.com,
	devel@...nvz.org
Subject: [PATCH] ext3: small fix for previous retries patch in ext3_prepare_write()

Patch from Dmitry Monakhov:
Previous fix for retries in ext3_prepare_write() violation
was a bit errorneuos:
- it missed return of error code from ext3_journal_stop()
- it missed do_journal_get_write_access() before commit_write

a few comments added also.

Signed-Off-By: Dmitry Monakhov <dmonakhov@...nvz.org>
Signed-Off-By: Kirill Korotaev <dev@...nvz.org>


diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index a48ada9..1acb528 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1162,13 +1162,14 @@ static int ext3_prepare_failure(struct f
 	struct buffer_head *bh, *head, *next;
 	unsigned block_start, block_end;
 	unsigned blocksize;
+	int ret;
+	handle_t *handle = ext3_journal_current_handle();
 
 	mapping = page->mapping;
 	if (ext3_should_writeback_data(mapping->host)) {
 		/* optimization: no constraints about data */
 skip:
-		ext3_journal_stop(ext3_journal_current_handle());
-		return 0;
+		return ext3_journal_stop(handle);
 	}
 
 	head = page_buffers(page);
@@ -1186,7 +1187,19 @@ skip:
 			break;
 		}
 		if (!buffer_mapped(bh))
+		/* prepare_write failed on this bh */
 			break;
+		if (ext3_should_journal_data(mapping->host)) {
+			ret = do_journal_get_write_access(handle, bh);
+			if (ret) {
+				ext3_journal_stop(handle);
+				return ret;
+			}
+		}
+	/*
+	 * block_start here becomes the first block where the current iteration
+	 * of prepare_write failed.
+	 */
 	}
 	if (block_start <= from)
 		goto skip;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/