[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20061128111414.A16460@unix-os.sc.intel.com>
Date: Tue, 28 Nov 2006 11:14:15 -0800
From: "Siddha, Suresh B" <suresh.b.siddha@...el.com>
To: Ingo Molnar <mingo@...e.hu>
Cc: "Siddha, Suresh B" <suresh.b.siddha@...el.com>,
mm-commits@...r.kernel.org, ak@...e.de, ashok.raj@...el.com,
akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] genapic: always use physical delivery mode on > 8 CPUs
On Tue, Nov 28, 2006 at 07:33:46AM +0100, Ingo Molnar wrote:
> - if (clusters <= 1 && max_cluster <= 8 && cluster_cnt[0] == max_cluster)
> + if (max_apic < 8)
Patch mostly looks good. Instead of checking for max_apic, can we use
cpus_weight(cpu_possible_map) <= 8
This will help where initially system booted with <= 8 cpus and hotplug
potentially can bringup more cpus later..
thanks,
suresh
> genapic = &apic_flat;
> else
> - genapic = &apic_cluster;
> +force_physflat:
> + genapic = &apic_physflat;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists