linux-kernel - Re: [PATCH 3/16] LTTng 0.6.36 for 2.6.18 : Linux Kernel Markers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	27 Nov 2006 21:23:17 -0500
From:	fche@...hat.com (Frank Ch. Eigler)
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@...l.org>, Ingo Molnar <mingo@...hat.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tom Zanussi <zanussi@...ibm.com>,
	Karim Yaghmour <karim@...rsys.com>,
	Paul Mundt <lethal@...ux-sh.org>, Jes Sorensen <jes@....com>,
	Richard J Moore <richardj_moore@...ibm.com>,
	"Martin J. Bligh" <mbligh@...igh.org>,
	Michel Dagenais <michel.dagenais@...ymtl.ca>,
	Douglas Niehaus <niehaus@...s.ku.edu>, ltt-dev@...fik.org,
	systemtap@...rces.redhat.com
Subject: Re: [PATCH 3/16] LTTng 0.6.36 for 2.6.18 : Linux Kernel Markers

Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> writes:

> This patch adds the Linux Kernel Markers [...]
> Signed-off-by : Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>

If it helps,
Acked-by: Frank Ch. Eigler <fche@...hat.com>


One question:

> [...]
> +	/* Markers in modules. */ 
> +	list_for_each_entry(mod, &modules, list) {
> +		if (mod->license_gplok)
> +			found += marker_set_probe_range(name, format, probe,
> +				mod->markers, mod->markers+mod->num_markers);
> +	}
> [...]
> +EXPORT_SYMBOL(marker_set_probe);

Are you sure the license_gplok check is necessary here?  We should
consider encouraging non-gpl module writers to instrument their code,
to give users a slightly better chance of debugging problems.


- FChE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/