linux-kernel - [PATCH 1/2] lib + ntfs: let modules force HWEIGHT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061128140840.f87540e8.randy.dunlap@oracle.com>
Date:	Tue, 28 Nov 2006 14:08:40 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	lkml <linux-kernel@...r.kernel.org>
Cc:	akpm <akpm@...l.org>, aia21@...tab.net
Subject: [PATCH 1/2] lib + ntfs: let modules force HWEIGHT

From: Randy Dunlap <randy.dunlap@...cle.com>

NTFS (=m) uses hweight32(), but that function is only linked
into the kernel image if it is used inside the kernel image,
not in loadable modules.  Let modules force HWEIGHT to be
built into the kernel image.  Otherwise build fails:

  Building modules, stage 2.
  MODPOST 94 modules
WARNING: "hweight32" [fs/ntfs/ntfs.ko] undefined!

Yes, I'd certainly prefer for this to be more automated rather than
forced by each module that needs it.

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
 fs/Kconfig   |    1 +
 lib/Kconfig  |    8 ++++++++
 lib/Makefile |    1 +
 3 files changed, 10 insertions(+)

--- linux-2.6.19-rc6-git10.orig/fs/Kconfig
+++ linux-2.6.19-rc6-git10/fs/Kconfig
@@ -816,6 +816,7 @@ config FAT_DEFAULT_IOCHARSET
 config NTFS_FS
 	tristate "NTFS file system support"
 	select NLS
+	select FORCE_HWEIGHT
 	help
 	  NTFS is the file system of Microsoft Windows NT, 2000, XP and 2003.
 
--- linux-2.6.19-rc6-git10.orig/lib/Kconfig
+++ linux-2.6.19-rc6-git10/lib/Kconfig
@@ -97,4 +97,12 @@ config TEXTSEARCH_FSM
 config PLIST
 	boolean
 
+#
+# FORCE_HWEIGHT support is select-ed if needed,
+# so that loadable modules can cause the kernel to supply it
+# (and not be dropped from lib.a when not used in kernel image)
+#
+config FORCE_HWEIGHT
+	boolean
+
 endmenu
--- linux-2.6.19-rc6-git10.orig/lib/Makefile
+++ linux-2.6.19-rc6-git10/lib/Makefile
@@ -28,6 +28,7 @@ lib-$(CONFIG_GENERIC_FIND_NEXT_BIT) += f
 lib-$(CONFIG_GENERIC_HWEIGHT) += hweight.o
 obj-$(CONFIG_LOCK_KERNEL) += kernel_lock.o
 obj-$(CONFIG_PLIST) += plist.o
+obj-$(CONFIG_FORCE_HWEIGHT) += hweight.o
 obj-$(CONFIG_DEBUG_PREEMPT) += smp_processor_id.o
 obj-$(CONFIG_DEBUG_LIST) += list_debug.o
 


---
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/