[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <39e6f6c70611271954s7cc3b6bbo237e333ae0d810ea@mail.gmail.com>
Date: Tue, 28 Nov 2006 01:54:43 -0200
From: "Arnaldo Carvalho de Melo" <arnaldo.melo@...il.com>
To: "Andrew Morton" <akpm@...l.org>
Cc: "David Howells" <dhowells@...hat.com>,
"Adrian Bunk" <bunk@...sta.de>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c
On 11/28/06, Andrew Morton <akpm@...l.org> wrote:
> On Mon, 27 Nov 2006 11:21:25 +0000
> David Howells <dhowells@...hat.com> wrote:
>
> > Adrian Bunk <bunk@...sta.de> wrote:
> >
> > > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the
> > > files with the actual functions.
> >
> > You can if you like. Can you slap a blank line before each EXPORT_SYMBOL()
> > though please?
>
> We have a mixture of both styles and given that they waste space in return
> for no added value, people have been gradually removing these blank lines
> in many places. Please don't add more.
Agreed, good thing would be if we could have something like
void foo(int bar) gpl_exported
{
}
I.e. some kind of __attribute__, nah, I should just get some sleep :-)
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists