linux-kernel - [patch] IRQ handler type mismatch for IRQ 14

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20061127110607.GA22050@elte.hu>
Date:	Mon, 27 Nov 2006 12:06:07 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org, Jeff Garzik <jgarzik@...ox.com>
Subject: [patch] IRQ handler type mismatch for IRQ 14

From: Ingo Molnar <mingo@...e.hu>
Subject: [patch] IRQ handler type mismatch for IRQ 14

got this with all SATA/PATA drivers enabled:

 Calling initcall 0xc05aceed: legacy_init+0x0/0x5b3()
 ata5: PATA max PIO4 cmd 0x170 ctl 0x376 bmdma 0x0 irq 14
 IRQ handler type mismatch for IRQ 14
 current handler: ide0
  [<c010501e>] dump_trace+0x64/0x1cc
  [<c010519f>] show_trace_log_lvl+0x19/0x2e
  [<c0105511>] show_trace+0x12/0x14
  [<c010552a>] dump_stack+0x17/0x19
  [<c016078f>] setup_irq+0x1c2/0x1dc
  [<c0160830>] request_irq+0x87/0xa7
  [<c02cc7c6>] ata_device_add+0x296/0x4dc
  [<c05ad3e0>] legacy_init+0x4f3/0x5b3
  [<c01004f9>] init+0x135/0x3c0
  [<c0104d67>] kernel_thread_helper+0x7/0x10

the patch below solves it, although i suspect the irq_flags field could 
be eliminated altogether now - all drivers must be prepared to handle 
shared interrupts.

Signed-off-by: Ingo Molnar <mingo@...e.hu>

Index: linux/drivers/ata/libata-core.c
===================================================================
--- linux.orig/drivers/ata/libata-core.c
+++ linux/drivers/ata/libata-core.c
@@ -5526,8 +5526,8 @@ int ata_device_add(const struct ata_prob
 	}
 
 	/* obtain irq, that may be shared between channels */
-	rc = request_irq(ent->irq, ent->port_ops->irq_handler, ent->irq_flags,
-			 DRV_NAME, host);
+	rc = request_irq(ent->irq, ent->port_ops->irq_handler,
+			 ent->irq_flags | SA_SHIRQ, DRV_NAME, host);
 	if (rc) {
 		dev_printk(KERN_ERR, dev, "irq %lu request failed: %d\n",
 			   ent->irq, rc);
@@ -5540,8 +5540,8 @@ int ata_device_add(const struct ata_prob
 		   so trap it now */
 		BUG_ON(ent->irq == ent->irq2);
 
-		rc = request_irq(ent->irq2, ent->port_ops->irq_handler, ent->irq_flags,
-			 DRV_NAME, host);
+		rc = request_irq(ent->irq2, ent->port_ops->irq_handler,
+				 ent->irq_flags | SA_SHIRQ, DRV_NAME, host);
 		if (rc) {
 			dev_printk(KERN_ERR, dev, "irq %lu request failed: %d\n",
 				   ent->irq2, rc);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/