linux-kernel - Re: [PATCH 1/2] lib + ntfs: let modules force HWEIGHT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <456CD957.2020002@oracle.com>
Date:	Tue, 28 Nov 2006 16:50:31 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Andrew Morton <akpm@...l.org>
CC:	lkml <linux-kernel@...r.kernel.org>, aia21@...tab.net
Subject: Re: [PATCH 1/2] lib + ntfs: let modules force HWEIGHT

Andrew Morton wrote:
> On Tue, 28 Nov 2006 14:08:40 -0800
> Randy Dunlap <randy.dunlap@...cle.com> wrote:
> 
>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>
>> NTFS (=m) uses hweight32(), but that function is only linked
>> into the kernel image if it is used inside the kernel image,
>> not in loadable modules.  Let modules force HWEIGHT to be
>> built into the kernel image.  Otherwise build fails:
>>
>>   Building modules, stage 2.
>>   MODPOST 94 modules
>> WARNING: "hweight32" [fs/ntfs/ntfs.ko] undefined!
>>
>> Yes, I'd certainly prefer for this to be more automated rather than
>> forced by each module that needs it.
> 
> Perhaps we should just put it in lib-y and remove CONFIG_GENERIC_HWEIGHT.
> It's either part of the API or it ain't.

Yes, that matches how I feel about it, but I expected some disagreement
(from elsewhere, not from you).

I'll send another patch later.  Replacement patch OK?  (vs. update)

-- 
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/