linux-kernel - Re: [2.6 patch] fs/sysv/: proper prototypes for 2 functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061129105750.GV11084@stusta.de>
Date:	Wed, 29 Nov 2006 11:57:50 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	Christoph Hellwig <hch@...radead.org>, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] fs/sysv/: proper prototypes for 2 functions

On Wed, Nov 29, 2006 at 10:06:00AM +0000, Christoph Hellwig wrote:
> On Wed, Nov 29, 2006 at 11:04:05AM +0100, Adrian Bunk wrote:
> > This patch adds proper prototypes for sysv_{init,destroy}_icache()
> > in sysv.h
> > 
> > Signed-off-by: Adrian Bunk <bunk@...sta.de>
> > 
> > ---
> > 
> >  fs/sysv/super.c |    3 ---
> >  fs/sysv/sysv.h  |    3 +++
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > --- linux-2.6.19-rc6-mm2/fs/sysv/sysv.h.old	2006-11-29 09:21:02.000000000 +0100
> > +++ linux-2.6.19-rc6-mm2/fs/sysv/sysv.h	2006-11-29 09:21:52.000000000 +0100
> > @@ -143,6 +143,9 @@
> >  extern int sysv_sync_file(struct file *, struct dentry *, int);
> >  extern void sysv_set_inode(struct inode *, dev_t);
> >  extern int sysv_getattr(struct vfsmount *, struct dentry *, struct kstat *);
> > +int sysv_init_icache(void);
> > +void sysv_destroy_icache(void);
> 
> Please follow the style used in the rest of the file and add the
> extern keyword.

Is it acceptable to remove all the extern's instead?

> > +
> 
> And don't add a superflous blank line.
> 
> Except for that the patch is fine.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/