[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20061129.120607.21923563.davem@davemloft.net>
Date: Wed, 29 Nov 2006 12:06:07 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: herbert@...dor.apana.org.au
Cc: a.p.zijlstra@...llo.nl, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, akpm@...l.org, mingo@...e.hu,
gandalf@...g.westbo.se
Subject: Re: [PATCH] lockdep: fix sk->sk_callback_lock locking
From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 29 Nov 2006 23:07:09 +1100
> On Wed, Nov 29, 2006 at 12:42:24PM +0100, Peter Zijlstra wrote:
> >
> > However I'm not quite sure yet how to teach lockdep about this. The
> > proposed patch will shut it up though.
>
> As a rule I think we should never make semantic changes to shut up
> lockdep.
Especially ones which are costly, as this proposed change is in
that it disables software interrupts in a place where that
is completely unnecessary.
Let's not even consider this patch :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists