linux-kernel - Re: net: sk98lin bracket question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061129145216.0722651b@freekitty>
Date:	Wed, 29 Nov 2006 14:52:16 -0800
From:	Stephen Hemminger <shemminger@...l.org>
To:	linux-kernel@...r.kernel.org
Subject: Re: net: sk98lin bracket question

On Wed, 29 Nov 2006 23:35:07 +0100
Mariusz Kozlowski <m.kozlowski@...land.pl> wrote:

> Hello,
> 
> 	Somewhere below is either one extra or one missing bracket. Any idea how to fix that?
> 
> Is the patch below correct?
> 
> --- linux-2.6.19-rc6-mm2-a/drivers/net/sk98lin/skgesirq.c	2006-11-16 05:03:40.000000000 +0100
> +++ linux-2.6.19-rc6-mm2-b/drivers/net/sk98lin/skgesirq.c	2006-11-29 23:32:02.000000000 +0100
> @@ -1319,7 +1319,7 @@ SK_BOOL	AutoNeg)	/* Is Auto-negotiation 
>  	SkXmPhyRead(pAC, IoC, Port, PHY_BCOM_INT_STAT, &Isrc);
>  
>  #ifdef xDEBUG
> -	if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT) ==
> +	if ((Isrc & ~(PHY_B_IS_HCT | PHY_B_IS_LCT)) ==
>  		(PHY_B_IS_SCR_S_ER | PHY_B_IS_RRS_CHANGE | PHY_B_IS_LRS_CHANGE)) {
>  
>  		SK_U32	Stat1, Stat2, Stat3;
> 
> 
> PS. Who is the maintainer of this driver?
> 

Nobody is maintaining this driver, it is being obsoleted and replaced by skge.

-- 
Stephen Hemminger <shemminger@...l.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/