linux-kernel - Re: [RFC][PATCH] Mount problem with the GFS2 code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061130002934.829334a6.akpm@osdl.org>
Date:	Thu, 30 Nov 2006 00:29:34 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Srinivasa Ds <srinivasa@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, Linus Torvalds <torvalds@...l.org>,
	swhiteho@...hat.com, fabbione@...ntu.com, bunk@...sta.de,
	aarora@...ux.vnet.ibm.com, aarora@...ibm.com
Subject: Re: [RFC][PATCH] Mount problem with the GFS2 code

On Thu, 30 Nov 2006 15:04:55 +0530
Srinivasa Ds <srinivasa@...ibm.com> wrote:

> ==========================================================================
> On debugging further we found that problem is while reading the super 
> block(gfs2_read_super) and comparing the magic number in it.
> When I  replace the submit_bio() call(present in gfs2_read_super) with 
> the sb_getblk() and ll_rw_block(), mount operation succeded.

umm, why on earth does gfs2_read_super() go direct-to-BIO?

Switching to sb_getblk()+ll_rw_blk() sounds like a preferable fix.

Even better would be switching to a bare sb_bread().   If sb->s_blocksize
isn't set up by then then either set it up or, if you must, use __bread().

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/