linux-kernel - Re: [PATCH] rtc: ds1743 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061130094723.6ab9e1d3@inspiron>
Date:	Thu, 30 Nov 2006 09:47:23 +0100
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	tr@...tec.dk
Cc:	a.zummo@...ertech.it, akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: ds1743 support

On Thu, 30 Nov 2006 08:12:02 +0100
Torsten Ertbjerg Rasmussen <tr@...tec.dk> wrote:

> The real time clocks ds1742 and ds1743 differs only in the size of the nvram. 
> This patch changes the existing ds1742 driver to support also ds1743. The 
> main change is that the nvram size is determined from the resource attached 
> to the device. 


> +	pdata->ioaddr_rtc = ioaddr + pdata->size_nvram;
>  
>  	/* turn RTC on if it was not on */
> +	ioaddr = pdata->ioaddr_rtc;
>  	sec = readb(ioaddr + RTC_SECONDS);

 why not
	sec = readb(pdata->ioaddr_rtc + RTC_SECONDS);
?


 Acked-by: Alessandro Zummo <a.zummo@...ertech.it>

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Turin, Italy

  http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/