[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20061130100731.GA6301@xyzzy.farnsworth.org>
Date: Thu, 30 Nov 2006 03:07:31 -0700
From: "Dale Farnsworth" <dale@...nsworth.org>
To: Mariusz Kozlowski <m.kozlowski@...land.pl>
Cc: dale@...nsworth.org, mlachwani@...sta.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mv643xx add missing brackets
On Thu, Nov 30, 2006 at 10:35:37AM +0100, Mariusz Kozlowski wrote:
> Hello,
>
> This patch adds missing brackets.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>
>
> include/linux/mv643xx.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.19-rc6-mm2-a/include/linux/mv643xx.h 2006-11-16 05:03:40.000000000 +0100
> +++ linux-2.6.19-rc6-mm2-b/include/linux/mv643xx.h 2006-11-30 01:10:53.000000000 +0100
> @@ -724,7 +724,7 @@
> #define MV643XX_ETH_RX_FIFO_URGENT_THRESHOLD_REG(port) (0x2470 + (port<<10))
> #define MV643XX_ETH_TX_FIFO_URGENT_THRESHOLD_REG(port) (0x2474 + (port<<10))
> #define MV643XX_ETH_RX_MINIMAL_FRAME_SIZE_REG(port) (0x247c + (port<<10))
> -#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER(port) (0x2484 + (port<<10)
> +#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER(port) (0x2484 + (port<<10))
Good. Thanks.
> #define MV643XX_ETH_PORT_DEBUG_0_REG(port) (0x248c + (port<<10))
> #define MV643XX_ETH_PORT_DEBUG_1_REG(port) (0x2490 + (port<<10))
> #define MV643XX_ETH_PORT_INTERNAL_ADDR_ERROR_REG(port) (0x2494 + (port<<10))
> @@ -1135,7 +1135,7 @@ struct mv64xxx_i2c_pdata {
> #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_1 (1<<19)
> #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_2 (1<<20)
> #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_3 ((1<<20) | (1<<19))
> -#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((1<<21)
> +#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((1<<21))
Mariusz, please remove the extra parenthesis instead of adding
an extra one, like:
#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 (1<<21)
and resubmit.
Thanks,
-Dale
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists