[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1164899084.5257.806.camel@gullible>
Date: Thu, 30 Nov 2006 10:04:44 -0500
From: Ben Collins <ben.collins@...ntu.com>
To: Roman Zippel <zippel@...ux-m68k.org>
Cc: linux-kernel@...r.kernel.org, torvalds@...l.org
Subject: Re: [PATCH 4/4] [HVCS] Select HVC_CONSOLE if HVCS is enabled.
On Thu, 2006-11-30 at 13:32 +0100, Roman Zippel wrote:
> Hi,
>
> On Wed, 29 Nov 2006, Ben Collins wrote:
>
> > If HVC_CONSOLE provides symbols that HVCS requires.
> >
> > Signed-off-by: Ben Collins <bcollins@...ntu.com>
> > ---
> > drivers/char/Kconfig | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> > index 2af12fc..c94ecdc 100644
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -598,6 +598,7 @@ config HVC_RTAS
> > config HVCS
> > tristate "IBM Hypervisor Virtual Console Server support"
> > depends on PPC_PSERIES
> > + select HVC_CONSOLE
> > help
> > Partitionable IBM Power5 ppc64 machines allow hosting of
> > firmware virtual consoles from one Linux partition by
>
>
> Why not a normal dependency?
Most of the HVC options are doing select on other HVC things (like
select HVC_DRIVER). So if this one needs to be a dependency, then it
would make more sense to clean up the HVC option group to do the same. I
just did the one-liner to make it work.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists